ci: update redirects with replace directive in s3 bucket#15109
Merged
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
Member
|
Goooooood question. TBH I forgot that was there; looks like that was part of e3cb726, but I'd have to dig as well to see how (and IF) it's still used. |
Member
|
A quick search tells me it's no longer used 🤔 but please double check if you find some reference to it |
Member
|
Oh! Perhaps I left it as a reminder to "include these as |
thaJeztah
reviewed
Jul 13, 2022
thaJeztah
requested changes
Jul 13, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
approved these changes
Jul 13, 2022
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I guess the only way to try this one is to merge and check docs-stage.docker.com ?
Member
Author
Yes indeed |
Merged
This was referenced Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles redirects generated by https://docs.docker.com/redirects.json in our s3 bucket by setting redirect requests for the objects. As our bucket is configured as a website, objects with redirects should have the proper 301 redirect status.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com